This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: Do not load all of a DAG into memory when pinning#2387
Merged
Conversation
b86bfa0 to
2761724
Compare
11 tasks
Port of #2372 into gc branch to ease merging
2761724 to
c4bf94c
Compare
alanshaw
approved these changes
Aug 23, 2019
dirkmc
reviewed
Aug 23, 2019
| } | ||
|
|
||
| getIndirectKeys (callback) { | ||
| getIndirectKeys ({ preload }, callback) { |
Contributor
There was a problem hiding this comment.
Do we want to preload when getting indirect keys?
Member
Author
There was a problem hiding this comment.
As implemented we leave it up to the caller and it's an undocumented option that defaults to false.
In general I think we want to be really careful with preloading because you can end up inadvertently sending huge amounts of data over the wire, maxing out the number of allowed connections, etc.
alanshaw
pushed a commit
that referenced
this pull request
Aug 26, 2019
Port of #2372 into gc branch to ease merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #2372 into gc branch to ease merging