Skip to content

fix: always render provider children#459

Merged
SgtPooki merged 1 commit intomasterfrom
fix/always-render-provider-children
Oct 31, 2024
Merged

fix: always render provider children#459
SgtPooki merged 1 commit intomasterfrom
fix/always-render-provider-children

Conversation

@SgtPooki
Copy link
Copy Markdown
Member

No description provided.

@SgtPooki SgtPooki requested a review from a team as a code owner October 31, 2024 17:50
Copy link
Copy Markdown
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review. note this PR also fixes loader color style


return (
<ExploreContext.Provider value={{ exploreState, explorePathPrefix, isLoading, doExploreLink, doExploreUserProvidedPath, doUploadUserProvidedCar, setExplorePath }} key={path}>
<ExploreContext.Provider value={{ exploreState, explorePathPrefix, isLoading, doExploreLink, doExploreUserProvidedPath, doUploadUserProvidedCar, setExplorePath }}>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having the key here was causing a double flash when clicking around.. I originally added it because webui wasn't getting updates.. but the setExplorePath resolves that I believe.

@SgtPooki SgtPooki merged commit c0ae357 into master Oct 31, 2024
@SgtPooki SgtPooki deleted the fix/always-render-provider-children branch October 31, 2024 17:54
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
## [8.0.5](v8.0.4...v8.0.5) (2024-10-31)

### Bug Fixes

* always render provider children ([#459](#459)) ([c0ae357](c0ae357))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant