Skip to content

fix: show '0 B' instead of '-' for zero-length files#2018

Merged
SgtPooki merged 1 commit intomainfrom
fix/2017
Sep 12, 2022
Merged

fix: show '0 B' instead of '-' for zero-length files#2018
SgtPooki merged 1 commit intomainfrom
fix/2017

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Sep 2, 2022

fixes #2017.

please check #2017 (comment) for more context

humanSize already takes care of undefined. I added a case for null.

@hacdias hacdias temporarily deployed to Deploy September 2, 2022 12:15 Inactive
@hacdias hacdias marked this pull request as ready for review September 2, 2022 12:22
@hacdias hacdias self-assigned this Sep 2, 2022
@SgtPooki SgtPooki merged commit fda3bf5 into main Sep 12, 2022
@SgtPooki SgtPooki deleted the fix/2017 branch September 12, 2022 16:10
ipfs-gui-bot pushed a commit that referenced this pull request Sep 13, 2022
## [2.18.1](v2.18.0...v2.18.1) (2022-09-13)

 CID `bafybeiageaoxg6d7npaof6eyzqbwvbubyler7bq44hayik2hvqcggg7d2y`

 ---

### Bug Fixes

* show '0 B' instead of '-' for zero-length files ([#2018](#2018)) ([fda3bf5](fda3bf5))
* update webui.ipfs.io dnslink on manual release ([#2024](#2024)) ([0f1e1c2](0f1e1c2)), closes [#2021](#2021)

### Tests

* add playwright code coverage ([#2014](#2014)) ([0ecc822](0ecc822))

### Trivial Changes

* pull transifex translations ([#2019](#2019)) ([5e59065](5e59065))
* **readme:** correct IPFS Desktop release link ([b76c0db](b76c0db))
* remove unused dependencies ([#2015](#2015)) ([f007d78](f007d78))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Zero length file does not show weight

3 participants