Skip to content

fix:macos ipfs-desktop left click no focus#2983

Closed
SAHU-01 wants to merge 1 commit intoipfs:mainfrom
SAHU-01:main
Closed

fix:macos ipfs-desktop left click no focus#2983
SAHU-01 wants to merge 1 commit intoipfs:mainfrom
SAHU-01:main

Conversation

@SAHU-01
Copy link
Copy Markdown

@SAHU-01 SAHU-01 commented Aug 15, 2025

This fixes #2943

Problem: On macOS, left-clicks on WebUI inputs didn’t focus because they sat inside an Electron draggable region (app-region: drag) that swallowed pointer events.
Solution: Injected CSS from the Electron shell to mark interactive controls as app-region: no-drag, restoring normal left/right click behavior across loads and in-page navigation.

@SAHU-01 SAHU-01 requested review from a team and SgtPooki as code owners August 15, 2025 06:25
@welcome
Copy link
Copy Markdown

welcome bot commented Aug 15, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging on best-effort basis, which may take multiple business. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

lidel added a commit to ipfs/ipfs-webui that referenced this pull request Aug 28, 2025
port fix from ipfs/ipfs-desktop#2983 to ensure interactive elements
(inputs, buttons, selects) work properly within electron's
draggable regions by setting app-region: no-drag

this resolves left-click focus issues on macos where inputs
were not receiving focus due to pointer events being blocked
Copy link
Copy Markdown
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @SAHU-01 ❤️

I think we want this to be fixed for all webui users, not just desktop ones.
Let's close this and instead fix this upstream in webui in ipfs/ipfs-webui#2416 – let's continue there

@lidel lidel closed this Aug 28, 2025
lidel added a commit to ipfs/ipfs-webui that referenced this pull request Sep 17, 2025
* fix: macos input focus issue in draggable regions

port fix from ipfs/ipfs-desktop#2983 to ensure interactive elements
(inputs, buttons, selects) work properly within electron's
draggable regions by setting app-region: no-drag

this aims to resolve left-click focus issues on macos where inputs
were not receiving focus due to pointer events being blocked

* docs: simplify css comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: browse/explore input field at the top of ipfs-desktop doesn't focus with macos with left click

2 participants