feat: make the CoreAPI expose a streaming pin interface#49
feat: make the CoreAPI expose a streaming pin interface#49Stebalien merged 3 commits intoipfs:masterfrom
Conversation
tests/block.go
Outdated
| pins, err := accPins(api.Pin().Ls(ctx)) | ||
| if err != nil { | ||
| return | ||
| t.Skip(err) |
There was a problem hiding this comment.
This is problematic. Before this PR, the test was just terminating and didn't actually test anything.
With this workaround, running the test suite in go-ipfs produce block.go:230: failed to decode Protocol Buffers: incorrectly formatted merkledag node: unmarshal failed. proto: PBNode: wiretype end group for non-group.
I don't know what the root cause is.
|
@MichaelMure that should fix your issue. Could you re-test? |
Stebalien
left a comment
There was a problem hiding this comment.
This looks like the simplest solution.
|
Originally this was blocked on releasing go-ipfs. However, I'm fine adding features to go-ipfs-http-client master and holding off on a release there until there's a go-ipfs release. |
|
@Stebalien can this be merged? |
|
Thanks for bumping this. |
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
Replace #38
This PR expose a streamed
pin/lsAPI.