Skip to content

chore: Adds codeowners#78

Merged
achingbrain merged 1 commit intomainfrom
feat/CODEOWNERS
Apr 6, 2023
Merged

chore: Adds codeowners#78
achingbrain merged 1 commit intomainfrom
feat/CODEOWNERS

Conversation

@whizzzkid
Copy link
Copy Markdown
Contributor

@whizzzkid whizzzkid commented Apr 5, 2023

Addresses: #35

Adding @ipfs/helia-dev as CODEOWNERS.

@whizzzkid whizzzkid mentioned this pull request Apr 5, 2023
Open
24 tasks
achingbrain
achingbrain requested changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click on "Files changed". It says "This CODEOWNERS file contains errors".

They need to be addressed before this can be merged.

@achingbrain achingbrain changed the title chore: 📝 Adding codeowners chore: Adding codeowners Apr 5, 2023
@achingbrain achingbrain changed the title chore: Adding codeowners chore: Adds codeowners Apr 5, 2023
@whizzzkid
Copy link
Copy Markdown
Contributor Author

whizzzkid commented Apr 6, 2023

@achingbrain fixed.

@whizzzkid whizzzkid requested a review from achingbrain April 6, 2023 07:05
@achingbrain achingbrain merged commit 3a39562 into main Apr 6, 2023
@achingbrain achingbrain deleted the feat/CODEOWNERS branch April 6, 2023 07:18
@BigLep
Copy link
Copy Markdown
Contributor

BigLep commented Apr 6, 2023

@whizzzkid : a few things here:

  1. We need this for the other Helia projects (ipns, unixfs) and idelia helia-examples (although I know it's a different org)
  2. You can actually declare CODEOWNERS in github-mgmt. That will allow you to have one PR that has the codeowners in all the helia examples (rather than doing a PR per repo). Here's an example PR where that was done: Add back broad push access to multicodec multiformats/github-mgmt#67 (your call of course)

@whizzzkid whizzzkid mentioned this pull request Apr 7, 2023
Merged
4 tasks
@whizzzkid
Copy link
Copy Markdown
Contributor Author

whizzzkid commented Apr 7, 2023

Thanks @BigLep for the guidance, should've known better. Created ipfs/github-mgmt#132 to tackle this.

achingbrain pushed a commit that referenced this pull request Jan 8, 2024
@web3-bot
chore: delete templates [skip ci] (#78)
84aec2b
@SgtPooki SgtPooki mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achingbrain achingbrain achingbrain approved these changes

@SgtPooki SgtPooki Awaiting requested review from SgtPooki

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whizzzkid @BigLep @achingbrain