This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Conversation
2 tasks
Member
|
Does FileArchive actually belong in this package? Or should we move it to go-ipfs-files as a helper for the TarWriter. It doesn't appear to be dag specific anymore. |
Member
Author
Yeah, it's a bit weird. Given that it is rather |
7736729 to
428fc30
Compare
Stebalien
approved these changes
Jan 30, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
Given that this package was, until recently, an internal of go-ipfs and nobody appears to be using DagArchive directly, LGTM.
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
Archive refactor This commit was moved from ipfs/go-unixfs@0eb1ef8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to happen for
ipfs getcoreapi refactorDepends on ipfs/go-ipfs-files#4