This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Conversation
This converts Resolver to an interface and leaves its implementation to the BasicResolver type. This should cause minimal distruption upstream (*Resolver -> Resolver) and opens the door to swap the BasicResolver for custom Resolvers.
27fabe4 to
2896296
Compare
|
@Jorropo : this has been assigned to you to review. |
Jorropo
suggested changes
Mar 23, 2022
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Resolver: convert to interface. This commit was moved from ipfs/go-path@3e5ff91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts Resolver to an interface and leaves its implementation to the
BasicResolver type.
This should cause minimal distruption upstream (*Resolver -> Resolver) and
opens the door to swap the BasicResolver for custom Resolvers.