ResolveToLastNode no longer fetches nodes it does not need#30
ResolveToLastNode no longer fetches nodes it does not need#30aschmahmann merged 2 commits intomasterfrom
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
06aa53a to
acc3a89
Compare
hsanjuan
left a comment
There was a problem hiding this comment.
I have the feeling there should be a way to rewrite the loop in a clearer way, but this makes sense anyways.
5cb05e7 to
c6b0980
Compare
c6b0980 to
6d87ec0
Compare
Stebalien
left a comment
There was a problem hiding this comment.
I think this is fine, but it could have unintended consequences. But the tests should cover it pretty well.
…kups ResolveToLastNode no longer fetches nodes it does not need This commit was moved from ipfs/go-path@1533d95
No description provided.