This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Conversation
ec9e1df to
2b85ea5
Compare
7 tasks
9 tasks
aschmahmann
reviewed
Apr 12, 2021
Contributor
Author
|
So what do we want to do here? Make the constructor take options and also remove the hard-coded shim for |
0e1deee to
7a6125f
Compare
Contributor
Author
|
Per discussion, I have updated the constructor to take options. |
Contributor
Author
|
also removed the special casing of |
lidel
approved these changes
Apr 19, 2021
Member
lidel
left a comment
There was a problem hiding this comment.
Removal of special-casing of .eth looks good.
Stebalien
approved these changes
Apr 21, 2021
See discussion in: #13 (review)
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
2e3a925 to
415b353
Compare
Contributor
Author
|
rebased on master and resolved the conflict; will go ahead and merge. |
Contributor
Author
|
seems travis is having some issues... |
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
make DNS resolver pluggable This commit was moved from ipfs/go-namesys@2454122
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
make DNS resolver pluggable This commit was moved from ipfs/go-namesys@2454122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ipfs/kubo#6532