This repository was archived by the owner on Oct 5, 2023. It is now read-only.
Merged
Conversation
41f699d to
3881ea0
Compare
3881ea0 to
df916c7
Compare
51 tasks
Stebalien
suggested changes
Feb 18, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
Mostly just nits at this point. However, this needs more documentation. I'm required by my OKRs to insist on this 😄.
Stebalien
reviewed
Feb 20, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
I'm a bit lost with Decode. I believe we want to assert that we get exactly one response, right? Or are we trying to decode the final response?
c4121e9 to
adbfda4
Compare
Stebalien
approved these changes
Feb 20, 2019
response.go
Outdated
| err = nil | ||
| } | ||
| return err | ||
| return json.NewDecoder(r.Output).Decode(dec) |
Member
There was a problem hiding this comment.
One final (I promise) nit: We should return the close error (could contain a trailing error).
decoder := json.NewDecoder(r.Output)
if err := decoder.Decode(dec); err != nil {
return err
}
return res.Close()
Stebalien
approved these changes
Feb 20, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
Nice! LGTM.
(although I'm not sure what's wrong with travis)
MichaelMure
reviewed
Feb 21, 2019
8123f58 to
95ce0f3
Compare
Member
Author
|
🚢 |
Jorropo
pushed a commit
to ipfs/kubo
that referenced
this pull request
May 30, 2023
Initial implementation This commit was moved from ipfs/go-ipfs-http-client@449b614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Unixfs.Get