Use trimpath for compatibility with go-ipfs v0.7.0#9
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
a88f62b to
5b63353
Compare
|
@Stebalien updated, take a look when you get a chance 🙏 |
5b63353 to
426ea45
Compare
This PR changes the build flags used when building plugins.
There are 3 types of go-ipfs we support building plugins against:
Previously:
Use the
-asmflags=all=-trimpath="$(GOPATH)" -gcflags=all=-trimpath="$(GOPATH)"flags no matter which version of the plugin we're building against.This was a pain when building against a Git commit/branch/tagged version of go-ipfs since the complex set of flags above had to be passed into
go get github.com/ipfs/go-ipfs/cmd/ipfs@{commit|branch|tag}. Additionally, the use of GOPATH here may not be correct depending on how the users' directory structure is set up.Now:
Use the
-asmflags=all=-trimpath="$(GOPATH)" -gcflags=all=-trimpath="$(GOPATH)"only when building against a locally build copy of go-ipfs, otherwise use the-trimpathflag instead.This means we can run
go get -trimpath github.com/ipfs/go-ipfs/cmd/ipfs@{commit|branch|tag}and just build the plugin with-trimpath(as done in the Makefile here) and things will work.