Merged
Conversation
add deduping requests by a given key to the response manager
use dedup extension to not dedup data across stores
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
updates to graphsync 0.2.0 which includes ipld-prime update also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Implementation
When you register alternate persistence stores, it's important to treat requests to those persistence stores as if they are a seperate peer.
This impliments a "dedup by key" extension which provides a way to say to a provider, for this peer, only dedup blocks in requests that also have this key.
On the provider, we simply use the alternate store name as the key