Merged
Conversation
Collaborator
Author
|
While I posted this PR, I'm not its author, and I'm LGTM-ing it. |
The 'testutil/chaintypes' codegen is currently dropped, and I ported the testchain fixtures to using basicnode instead. We can restore this to using codegen soon, but it's easier to complete this set of changes by temporarily switching to using basicnode. Tests using 'NewUnencodableSelectorSpec' were discarded -- this more or less exercised what would happen if an uninitialized zero value got into a program, and this is now happily statically impossible. Some tests are not passing; have not sussed yet.
use ipld prime with fixed marshalling bug to get tests passing
ac7d472 to
af2cff9
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
docs(CHANGELOG): update for 0.6.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Update IPLD prime to node assembler style
Impelmentation
Per @warpfork