Skip to content

Use external pubsub#65

Merged
hannahhoward merged 1 commit intomasterfrom
feat/refactor-use-pubsub
Apr 28, 2020
Merged

Use external pubsub#65
hannahhoward merged 1 commit intomasterfrom
feat/refactor-use-pubsub

Conversation

@hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Apr 23, 2020

Goals

Reduce copy-pasta around setting up subscriptions, avoid accidental mutex errors with subscription lists

Implementation

  • use a little library https://github.com/hannahhoward/go-pubsub that implements this functionality in a generic way
  • remove non-specific logic from all the hooks.
  • also using this pattern in go-data-transfer, go-fil-markets in filecoin ecosystem, repo can move into PL namespace if someone is willing to own it (it's not functionality that is particularly IPFS-ey or Filecoin-ey)

@hannahhoward hannahhoward force-pushed the feat/refactor-use-pubsub branch from 32234c6 to cdab402 Compare April 23, 2020 23:05
@hannahhoward hannahhoward force-pushed the feat/refactor-use-pubsub branch from cdab402 to f35cd56 Compare April 28, 2020 20:14
@hannahhoward hannahhoward merged commit 97a8cf7 into master Apr 28, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
@mvdan mvdan deleted the feat/refactor-use-pubsub branch December 15, 2021 14:16
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
* fix(graphsync): improve graphsync error logging

* feat(graphsync): update graphsync dedpendency

also test simultaneous custom stores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant