Merged
Conversation
6284ce1 to
e42842b
Compare
add update to message protobuf. also fix deserialization error with cancel requests
Support sending request updates in incoming response hooks. Also factor hooks out of request manager
for ease of use and learning in library, make hooks structure consistent across requestor and responder
Add the ability to processing update requests as needed
Add test to verify the whole update flow
7f06479 to
dfcd677
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Implement ipld/specs#258, support a pause/resume flow through hooks
Implementation
Not Addressed: functionality to apply updates to modify the original request -- it makes sense that this may be something we want to do, but exactly what it looks like is a bit nebulous, so I'm not trying to figure out the exact right approach now