Merged
Conversation
cb5665a to
833fdd3
Compare
Introduce testify, cleanup lots of tests, add channel assertions to simplify channel tests, make more readable
remove accidentally added bitswap
Make sure for require.equal that the expected value is the first value
a523327 to
db1e49e
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* fix(types): cbor-gen for channel ID * fix(impl): better voucher decoder use both type registries to decode vouchers in channels * refactor(channels): use go-statemachine GetSync rather than clunky noopSynchronize event, use built in GetSync method in go-statemachine * feat(channels): add channel id to channel state * fix(impl): fix integration test Not sure how this was managing to work given how it's written! * fix(deps): update go-statemachine * fix(impl): fix test stability was failng in situations with where request completed, due to timing issues. * fix(deps): update go-statemachine * fix(impl): revalidation sends complete responses make sure the revalidation sends a different message for a response that is finalizing versus regular * fix(fsm): allow progress at start * fix(deps): update graphsync * feat(transport): cleanup channels after complete do not cleanup channels until transfer is definitely complete * fix(deps): update go-graphsync to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Graphsync is big and has lots of tests. Those tests are not very easy to reach particularly because they involve a lot of tests on channels. This PR introduces Testify and a few utility functions to make the tests vastly more readable and clearer in intent.
Implementation