This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Separate implementation and fix types#16
Merged
hannahhoward merged 6 commits intomainfrom Apr 19, 2021
Merged
Conversation
move block service implementation to its own package. move traversal helpers to traversal directory
define an interface for making new instances of the fetcher
willscott
approved these changes
Apr 10, 2021
update parameter names on interface to be more clear
willscott
approved these changes
Apr 10, 2021
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…fix-types Separate implementation and fix types This commit was moved from ipfs/go-fetcher@d24b660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Per discussions with @aschmahmann, this PR moves the implementation to a separate package from the interfaces. It also makes the fetching functions take ipld.Node's instead of parsed selectors.
Implementation