This repository was archived by the owner on Feb 1, 2023. It is now read-only.
contexts: make sure to abort when a context is canceled#58
Merged
Conversation
Also, buffer single-use channels we may walk away from. This was showing up (rarely) in a go-ipfs test.
Member
Author
|
(for the record, this is one of the most annoying parts of go...) |
Member
Author
|
Ideally, this would get a test or two but this isn't really a critical code path. It only shows up on shutdown (where we usually don't wait around anyways). However, if someone has time... |
Contributor
|
Definitely fair! LGTM |
hannahhoward
approved these changes
Jan 23, 2019
Contributor
hannahhoward
left a comment
There was a problem hiding this comment.
LGTM, shoulda caught these!
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…cancel contexts: make sure to abort when a context is canceled This commit was moved from ipfs/go-bitswap@f016167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, buffer single-use channels we may walk away from. This was showing up (rarely) in a go-ipfs test (test/integration.Test1KBInstantaneous).