Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 60.34% 60.44% +0.10%
==========================================
Files 244 244
Lines 31029 31027 -2
==========================================
+ Hits 18723 18753 +30
+ Misses 10634 10606 -28
+ Partials 1672 1668 -4
|
Ls to take a results channel instead of returning oneLs to take results channel instead of returning one
hsanjuan
approved these changes
Dec 3, 2024
Ls to take results channel instead of returning oneLs to take results channel instead of returning one
lidel
approved these changes
Dec 3, 2024
Member
There was a problem hiding this comment.
Thank you, I'm merging and bubbling up to ipfs/kubo#10527, will include this in Kubo 0.33.0-rc1
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 3, 2024
lidel
pushed a commit
to ipfs/kubo
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new client
LsAPI that takes a write-only results channel instead of returns one. This is needed by ipfs/kubo#10527The original
Lsbehavior is implemented by theGoLsfunction, which creates the channels, starts the goroutine that callsLs, and returns the channels to the caller.