Merged
Conversation
This reverts commit 236e39e.
Jorropo
approved these changes
May 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 47.92% 48.00% +0.07%
==========================================
Files 280 279 -1
Lines 33521 33439 -82
==========================================
- Hits 16066 16051 -15
+ Misses 15768 15702 -66
+ Partials 1687 1686 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #292.
Let's add some tests and improve the interface. The names are too coupled with
ipfs name inspectcommand and may not make sense in Boxo. I didn't notice this when I was going over the Boxo PR, only later when looking at ipfs/kubo#9867