Merged
Conversation
This was referenced May 9, 2023
Contributor
Author
|
(moving to draft until I fix the errors) |
f32a1af to
00d0974
Compare
This reverts commit 00d0974.
Contributor
Author
|
Thanks for updating the PR @hacdias, that looks great! |
e6053af to
2d50508
Compare
Jorropo
approved these changes
May 10, 2023
Contributor
Jorropo
left a comment
There was a problem hiding this comment.
LGTM, good to merge once merged and commit ID updated in go.mod here too.
hacdias
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR in boxo: ipfs/boxo#294
Extracts the ipns verification code out of kubo to boxo. This makes the verification code reusable, for example, with gateway-conformance testing (ipfs/gateway-conformance#37)
Relates to ipfs/specs#376