Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 19.62% 25.98% +6.36%
==========================================
Files 100 100
Lines 11053 11053
==========================================
+ Hits 2169 2872 +703
+ Misses 8597 7839 -758
- Partials 287 342 +55
|
989a077 to
c48010d
Compare
c48010d to
0d5f0a9
Compare
0d5f0a9 to
222bbd9
Compare
222bbd9 to
888fe00
Compare
lidel
approved these changes
Feb 14, 2023
Member
lidel
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up ❤️
| return &mockApi{ | ||
| ns: mockNamesys{}, | ||
| func newMockAPI(t *testing.T) (*mockAPI, cid.Cid) { | ||
| r, err := os.Open("./testdata/fixtures.car") |
Member
There was a problem hiding this comment.
@hacdias fysa I've moved fixtures to testdata/ subdir, it seems to be a good convention to follow in future:
The go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.
–go help test
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #146. Migrates remaining gateway Go tests from Kubo (see removal in Kubo: ipfs/kubo#9627). Since we don't have a UnixFS API here, I created a
fixtures.carfile. This file has a single root. Under that root, there is a directory for each test (that requires data) with the name of the test.