feat: add new hex address equivalence for mainnet profiles#8717
Merged
begonaalvarezd merged 7 commits intoJun 4, 2025
Merged
Conversation
brancoder
reviewed
May 27, 2025
brancoder
left a comment
Collaborator
There was a problem hiding this comment.
the task states to
Below the receive funds, add a new copiable box with the new address equivalence
In the task the address has been added to the same box as receive funds, should we push it under to a dedicated box?
begonaalvarezd
requested changes
May 30, 2025
begonaalvarezd
left a comment
Member
There was a problem hiding this comment.
I think we are still missing the hex in the address history
We should display the address on each bip path and allow to copy it, and also allow to copy all by either adding it to the comma separated addresses or adding a new button for the new format specifically
brancoder
requested changes
Jun 2, 2025
brancoder
left a comment
Collaborator
There was a problem hiding this comment.
we should add the copy all button for new hex address formats as requested in this comment
#8717 (review)
begonaalvarezd
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #8716
...
Changelog
Testing
Platforms
Instructions
...
Checklist