fix(nullRef): nullify reference to the destroyed slider#5377
Merged
adamdbradley merged 1 commit intoionic-team:masterfrom Feb 10, 2016
Merged
fix(nullRef): nullify reference to the destroyed slider#5377adamdbradley merged 1 commit intoionic-team:masterfrom
adamdbradley merged 1 commit intoionic-team:masterfrom
Conversation
…rom calling update())
adamdbradley
added a commit
that referenced
this pull request
Feb 10, 2016
fix(nullRef): nullify reference to the destroyed slider
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ionic team.
I've got an issue today with
ionSlides, using it in aui-view. When leaving the view containing the slider, by loading another one into theui-view, theupdatemethod ofionSlideswas triggered and executed_this.__slider.update()in spite of the "falsy-check" just before. Indeed, the instance of the slider is kept even after the slider is destroyed (because of $scope$destroyevent).A simple PR to nullify the reference after the slider is destroyed.
In order for this piece of code to work properly: