Fix ionSlidePage destroy#5121
Merged
adamdbradley merged 3 commits intoionic-team:masterfrom Jan 22, 2016
jlcarvalho:master
Merged
Fix ionSlidePage destroy#5121adamdbradley merged 3 commits intoionic-team:masterfrom jlcarvalho:master
adamdbradley merged 3 commits intoionic-team:masterfrom
jlcarvalho:master
Conversation
adamdbradley
added a commit
that referenced
this pull request
Jan 22, 2016
fix(ionSlidePage): update slider on destroy
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
<ion-slide-page>directive is destroyed, the slider is not updated.This PR fix the issue related in #5120 adding a destroy event in the directive.