Fix e.detail.keyboardHeight undefined error in keyboardAttach directive#4357
Merged
mlynch merged 1 commit intoionic-team:masterfrom Dec 6, 2015
Merged
Fix e.detail.keyboardHeight undefined error in keyboardAttach directive#4357mlynch merged 1 commit intoionic-team:masterfrom
e.detail.keyboardHeight undefined error in keyboardAttach directive#4357mlynch merged 1 commit intoionic-team:masterfrom
Conversation
…tive My background: - newest ionic - newest ionic cordova keyboard plugin installed - iOS 8 + iPhone 5C - debugging through Safari Emulator What happens: When focusing on the input in `<ion-footer-bar keyboard-attach>`, I get a `TypeError: undefined is not an object (evaluating 'e.detail.keyboardHeight')` error. This bugfix fixes it.
e.detail.keyboardHeight undefined error in keyboardAttach direc…e.detail.keyboardHeight undefined error in keyboardAttach directive
|
Bump, I have this same bug. @jtomaszewski do you know what is actually causing this event to not have |
Author
|
I've no idea. |
Contributor
|
Tracking for 1.2, thanks |
mlynch
added a commit
that referenced
this pull request
Dec 6, 2015
Fix `e.detail.keyboardHeight` undefined error in keyboardAttach directive
Contributor
|
Err, one liner easy to merge 😄 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My background:
What happens:
When focusing on the input in
<ion-footer-bar keyboard-attach>, I get aTypeError: undefined is not an object (evaluating 'e.detail.keyboardHeight')error.This bugfix fixes it.