Skip to content

Make ionRefresher promise-friendly#4222

Merged
mlynch merged 1 commit intoionic-team:masterfrom
beauby:refresher-promise
Dec 6, 2015
Merged

Make ionRefresher promise-friendly#4222
mlynch merged 1 commit intoionic-team:masterfrom
beauby:refresher-promise

Conversation

@beauby
Copy link
Copy Markdown

@beauby beauby commented Aug 12, 2015

Make ionRefresher play ball when onRefresh function returns a promise.

@mhartington
Copy link
Copy Markdown
Contributor

mhartington commented Aug 12, 2015

Do you have an example for how this change PTR? Also, could you provide a test for this?

@beauby
Copy link
Copy Markdown
Author

beauby commented Aug 12, 2015

Here is an example:

var myRefreshFunction = function() {
  return fetchNewData();
};

instead of

var myRefreshFunction = function() {
  fetchNewData().finally(function() {
    $scope.$broadcast('scroll.refreshComplete');
  });
};

Note that this commit PR is backwards compatible.

@markspolakovs
Copy link
Copy Markdown

markspolakovs commented Sep 18, 2015

👍

@ryanlin1986
Copy link
Copy Markdown

ryanlin1986 commented Sep 18, 2015

This is really good.

@mhartington
Copy link
Copy Markdown
Contributor

mhartington commented Sep 18, 2015

I'll let @perrygovier take a look at this.

@beauby
Copy link
Copy Markdown
Author

beauby commented Oct 7, 2015

Any feedback on this one?

@perrygovier perrygovier added this to the 1.2 milestone Oct 8, 2015
mlynch added a commit that referenced this pull request Dec 6, 2015
@mlynch
Merge pull request #4222 from beauby/refresher-promise
d1f31a4 
Make ionRefresher promise-friendly
@mlynch mlynch merged commit d1f31a4 into ionic-team:master Dec 6, 2015
@mlynch
Copy link
Copy Markdown
Contributor

mlynch commented Dec 6, 2015

👍 🍕 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@perrygovier perrygovier

Labels

None yet

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

6 participants

@beauby @mhartington @markspolakovs @ryanlin1986 @mlynch @perrygovier