fix(android): Integer conversion of compileSdk/minSdk/targetSdk#5195
Closed
saschpe wants to merge 1 commit intoionic-team:mainfrom
Closed
fix(android): Integer conversion of compileSdk/minSdk/targetSdk#5195saschpe wants to merge 1 commit intoionic-team:mainfrom
saschpe wants to merge 1 commit intoionic-team:mainfrom
Conversation
a2a4995 to
c64101e
Compare
6f65770 to
59c629c
Compare
59c629c to
7eaf0f6
Compare
7eaf0f6 to
529761c
Compare
529761c to
01611b8
Compare
01611b8 to
4d4b478
Compare
Contributor
Author
|
I would be nice if someone could provide some feedback for this fix. Thanks. |
4d4b478 to
4dcf3b6
Compare
4dcf3b6 to
2ad7dac
Compare
Contributor
Author
|
I would appreciate if this could be looked at. At the moment it is not possible to put this into one's gradle.properties, simply because those are interpreted as strings: |
2ad7dac to
f55c93e
Compare
f55c93e to
35a1b96
Compare
Gradle properties are always parsed as strings from `gradle.properties`. While Gradle Groovy can utilize the `ext` Gradle plugin directly, Gradle Kotlin DSL projects have to specify properties in `gradle.properties`. Convert those to integers as required by Android Gradle Plugin (AGP). This won't affect projects that still use Gradle Groovy. Resolves ionic-team#5194
35a1b96 to
6e2dec2
Compare
Contributor
Author
|
Final ping, I think this is still relevant. Worth rebasing once more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle properties are always parsed as strings from
gradle.properties. While Gradle Groovy can utilize theextGradle plugin directly, Gradle Kotlin DSL projects have to specify properties ingradle.properties. Convert those to integers as required by Android Gradle Plugin (AGP). This won't affect projects that still use Gradle Groovy.Resolves #5194