fix(android): Integer conversion of compileSdk/minSdk/targetSdk#677
Closed
saschpe wants to merge 1 commit intoionic-team:mainfrom
Closed
fix(android): Integer conversion of compileSdk/minSdk/targetSdk#677saschpe wants to merge 1 commit intoionic-team:mainfrom
saschpe wants to merge 1 commit intoionic-team:mainfrom
Conversation
8ad1030 to
68e7edb
Compare
b8f8316 to
a717e57
Compare
a717e57 to
bfce275
Compare
bfce275 to
6680673
Compare
6680673 to
a13e54b
Compare
a13e54b to
30235bc
Compare
30235bc to
a25529e
Compare
a25529e to
4655c7c
Compare
4655c7c to
bee9d41
Compare
Gradle properties are always parsed as strings from `gradle.properties`. While Gradle Groovy can utilize the `ext` Gradle plugin directly, Gradle Kotlin DSL projects have to specify properties in `gradle.properties`. Convert those to integers as required by Android Gradle Plugin (AGP). This won't affect projects that still use Gradle Groovy. Resolves #ionic-team/capacitor#5194
bee9d41 to
e22cfda
Compare
Author
|
Final ping, I think this is still relevant. Worth rebasing once more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle properties are always parsed as strings from
gradle.properties.While Gradle Groovy can utilize the
extGradle plugin directly, GradleKotlin DSL projects have to specify properties in
gradle.properties.Convert those to integers as required by Android Gradle Plugin (AGP).
This won't affect projects that still use Gradle Groovy.
Resolves #ionic-team/capacitor#5194