fix: Unsigned int handling (0 is a valid value)#105
Merged
samlown merged 1 commit intoinvopop:mainfrom Oct 2, 2023
Merged
Conversation
Contributor
Author
|
@samlown this is a minor bug here (0 should be allowed), but I'd love to get a release with this fix, too |
This was referenced Oct 2, 2023
samlown
approved these changes
Oct 2, 2023
Contributor
|
Looks great! thanks. |
Contributor
Author
|
@samlown could you please push a new tag? |
Contributor
|
@candiduslynx release on the way, but you might also find it easier to just use a specific commit in your code base as opposed to solely relying on new versions. |
kodiakhq bot
pushed a commit
to cloudquery/codegen
that referenced
this pull request
Oct 2, 2023
Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/plugin-sdk#1254
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 2, 2023
Follow-up for #13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Follow-up for cloudquery#13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following validations are fixed or are moved to proper type def at least: