Skip to content

Fix Jobs Not Being Updated To Complete After Completing Test#387

Merged
Zakaria-Kofiro merged 16 commits intomasterfrom
zkofiro/clean-up-completed-jobs
May 9, 2025
Merged

Fix Jobs Not Being Updated To Complete After Completing Test#387
Zakaria-Kofiro merged 16 commits intomasterfrom
zkofiro/clean-up-completed-jobs

Conversation

@Zakaria-Kofiro
Copy link
Collaborator

title: -

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review March 20, 2025 19:28
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why the new variable sendFinalUpdate. It appears to always have the same value as doMonitor
  • Please no, adding INFO logs. Can you make them DEBUG?

@Zakaria-Kofiro Zakaria-Kofiro merged commit a307b26 into master May 9, 2025
3 checks passed
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/clean-up-completed-jobs branch May 9, 2025 15:00
kevin-mcgoldrick added a commit that referenced this pull request May 10, 2025
* master:
  Jexl3 Updates (#396)
  Increment 1% more coverage (#397)
  Fix Jobs Not Being Updated To Complete After Completing Test (#387)
  Bump org.jruby:jruby from 9.4.6.0 to 9.4.12.1 (#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants