Skip to content

Add Ruby 3.0 to test matrix#202

Merged
sferik merged 1 commit into
intridea:masterfrom
BuonOmo:ruby3
Mar 11, 2024
Merged

Add Ruby 3.0 to test matrix#202
sferik merged 1 commit into
intridea:masterfrom
BuonOmo:ruby3

Conversation

@BuonOmo

@BuonOmo BuonOmo commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

I've added some support for ruby 3.0 in travis configuration. The quotes are just here in case you choose to move to GitHub actions, I can get rid of it if need be.

More on Travis VS GitHub actions. Support for open source from travis has gone missing (https://news.ycombinator.com/item?id=25155203), I can make a next PR moving from travis to github actions if you want 🙂. Done that for most of my repos now, it is easy and support matrix as well (and support windows if you ever want to add tests for it)

If I am to make that PR, may I remove tests for unsupported ruby versions (1.8 up to 2.4, https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/)?

Thanks for the great gem!

@djberg96

Copy link
Copy Markdown
Contributor

@BuonOmo Any chance you could add 3.1, 3.2 and 3.3? I know 3.2+ will break, but it should start passing again if/when #205 is merged.

@BuonOmo

BuonOmo commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

@djberg96 done, but TBH I'm not sure the author will consider it. Also I could help migrating to github actions...

Ping @intridea-shared

@djberg96

Copy link
Copy Markdown
Contributor

@BuonOmo Agreed, github actions would be nice.

@sferik sferik merged commit fafcd6f into intridea:master Mar 11, 2024
@BuonOmo BuonOmo deleted the ruby3 branch March 12, 2024 02:19
@sferik

sferik commented Mar 12, 2024

Copy link
Copy Markdown
Member

Thanks for submitting this!

I would definitely accept a patch that migrated CI to GitHub Actions. Is this something you’re still interested in working on?

@BuonOmo

BuonOmo commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

I would definitely accept a patch that migrated CI to GitHub Actions. Is this something you’re still interested in working on?

Yes, this will need a little bit of configuration on your hand in the end though.

@sferik

sferik commented Mar 12, 2024

Copy link
Copy Markdown
Member

I don't think I actually have permission to do this, but someone from Intridea should be able to help.

@BuonOmo

BuonOmo commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

@sferik the PR is up and ready FYI, see #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants