feat(ci): switch to github action#210
Merged
Merged
Conversation
d96af4e to
4de6dce
Compare
Member
|
Looks good! Thanks for the quick patch. I am able to create a |
Member
|
Just merged this but noticed one more change that needs to be made: the build status badge in the |
Contributor
Author
|
EDIT: PR done here #212 Arf I forgot it... Could you add it committing directly ? main master
I could do the PR once the branch is changed otherwise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sferik
json_puretests are failing. I skept them as I don't understand what is the issue about. I think it is better to have tests like this to avoid further regressions and then look for the issue. I'll be less disponible next days, so here's a mergeable (IMHO) proposalYou'd have to activate Gihub Actions for the project, and branch protect master (and rename it ? <3)