Skip to content

Upgrade ci#221

Merged
mlodic merged 4 commits intodevelopfrom
upgrade_ci2
Sep 6, 2023
Merged

Upgrade ci#221
mlodic merged 4 commits intodevelopfrom
upgrade_ci2

Conversation

@0ssigeno
Copy link
Copy Markdown
Contributor

@0ssigeno 0ssigeno commented Sep 6, 2023

No description provided.

@mlodic mlodic merged commit 2b40290 into develop Sep 6, 2023
@0ssigeno 0ssigeno deleted the upgrade_ci2 branch September 6, 2023 09:49
opbot-xd added a commit to opbot-xd/GreedyBear that referenced this pull request Jan 1, 2026
5a78179 Merge pull request intelowlproject#223 from certego/develop
76df2c2 added ruff and fixed a bug (intelowlproject#221)
59bfe83 Explicitly disabled "xpack.security" in Elasticsearch container
0c262e2 Updated CHANGELOG
0599640 Fixed create_python_cache workflow (intelowlproject#222)
4f21023 Added documentation - part 2 (intelowlproject#220)
0d2f931 updated github actions versions (intelowlproject#218)
013f31a Python caching revisited (intelowlproject#217)
548235b Linter requirements reconciliated (intelowlproject#215)
b6fd709 Updated changelog
0cfa137 Ecr (intelowlproject#201)
ed2dd16 Updated codeQL action to v3 (intelowlproject#216)
5f44be8 APT caching revisited (intelowlproject#214)
cf7c16d Updated linters and added changes detection exclusions (intelowlproject#213)
a492676 Deprecation of license check `table-headers` (intelowlproject#212)
0a6db48 Updated python linters also in '_python.yml' workflow

git-subtree-dir: .github
git-subtree-split: 5a78179ab0cbea826c416f8975251b519c2541fc
mlodic pushed a commit that referenced this pull request Jan 3, 2026
* Squashed '.github/' changes from aa1fe1a..5a78179

5a78179 Merge pull request #223 from certego/develop
76df2c2 added ruff and fixed a bug (#221)
59bfe83 Explicitly disabled "xpack.security" in Elasticsearch container
0c262e2 Updated CHANGELOG
0599640 Fixed create_python_cache workflow (#222)
4f21023 Added documentation - part 2 (#220)
0d2f931 updated github actions versions (#218)
013f31a Python caching revisited (#217)
548235b Linter requirements reconciliated (#215)
b6fd709 Updated changelog
0cfa137 Ecr (#201)
ed2dd16 Updated codeQL action to v3 (#216)
5f44be8 APT caching revisited (#214)
cf7c16d Updated linters and added changes detection exclusions (#213)
a492676 Deprecation of license check `table-headers` (#212)
0a6db48 Updated python linters also in '_python.yml' workflow

git-subtree-dir: .github
git-subtree-split: 5a78179ab0cbea826c416f8975251b519c2541fc

* Simplify pre-commit to use only Ruff

- Removed black, isort, flake8, pylint, bandit, autoflake from pre-commit
- Ruff provides equivalent functionality for all of these
- Faster pre-commit execution
- Avoids conflicting linter rules

* Update documentation to reflect Ruff migration

- Replaced black and isort badges with Ruff badge in README
- Updated PR template checklist to mention Ruff instead of Black/Flake/Isort

* Run Ruff to fix linting and formatting issues

- Fixed 37 import sorting and unused import issues
- Reformatted 5 files with ruff format
- Fixed pre-commit ruff args (removed invalid 'check' argument)
- 14 wildcard import warnings remain (F403) which require manual review

* Add .ruff_cache to .gitignore

- Exclude Ruff's cache directory from version control

* Silence F403 wildcard import warnings

As per maintainer feedback, silenced F403 warnings for wildcard imports in __init__.py files since they are acceptable for this project.

* Add pyproject.toml and fix migration file imports

- Created pyproject.toml to extend ruff config for easier CLI usage
- Fixed import sorting in 5 Django migration files
- Now 'ruff check .' works without explicit --config flag

* Apply ruff formatting to remaining files

- Reformatted 30 Python files with ruff format
- This is the result of running 'ruff format .' after creating pyproject.toml
- No logic changes, only formatting (line breaks, spacing)

* Add empty packages.txt for certego/.github v2.0.0 compatibility

The new certego/.github v2.0.0 APT cache workflow requires a packages
file, even if empty. This is a workaround for the workflow's strict
validation that was introduced in v2.0.0.

* Add packages_path to workflow configuration

Pass packages.txt to the workflow to fix APT cache restoration step

* Make packages.txt truly empty

Remove comments that were being interpreted as package names by apt-get

* Specify RabbitMQ version for CI

Use rabbitmq:4-management-alpine to fix Docker image pull error.
The default 'latest' is not a valid tag for management-alpine images.

* Fix RabbitMQ version tag duplication

Use version '4' instead of '4-management-alpine' since the workflow
automatically appends '-management-alpine' suffix

* Expand Ruff rule coverage with comprehensive linting modules

Added comprehensive Ruff rule modules as requested:
- E/W: Full pycodestyle error and warning coverage
- N: pep8-naming for naming conventions
- UP: pyupgrade for modern Python syntax
- B: flake8-bugbear for common Python bugs
- C4: flake8-comprehensions for list/dict improvements
- DJ: flake8-django for Django-specific linting

All rules are documented with inline comments and links to official docs.

Fixed 43 auto-fixable violations (imports, annotations, etc).
Added comprehensive ignore list for intentional code patterns:
- Test helpers (mutable defaults, classmethods)
- ML conventions (X, X_train naming)
- Django patterns (null=True on CharField, models without __str__)
- Legacy naming (viewType, iocType, migration functions)

All checks passing ✅

* Fix easy E/N/UP/C violations as requested

Applied Ruff auto-fixes for straightforward style improvements:
- N804: Renamed 'self' → 'cls' in test classmethods (6 occurrences)
- UP008: Simplified super() calls (3 occurrences)
- UP031/UP032: Modernized string formatting (2 occurrences)
- C401: Fixed set comprehensions (7 occurrences)

Total: 18 violations fixed across 7 files.

Invasive changes (N801/N802 model/function renames, N803/N806 ML naming)
deferred to follow-up issue for dedicated testing and review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants