Skip to content

React environment variables#182

Merged
mlodic merged 1 commit intodevelopfrom
react_env
Jun 8, 2023
Merged

React environment variables#182
mlodic merged 1 commit intodevelopfrom
react_env

Conversation

@carellamartina
Copy link
Copy Markdown
Collaborator

@carellamartina carellamartina commented Jun 8, 2023

Description

added possibility to read react environment variables at runtime

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project.
  • The pull request is for the branch develop.
  • I have added documentation of the new features.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved. All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@carellamartina carellamartina requested a review from mlodic June 8, 2023 07:33
@mlodic mlodic merged commit df9bcd1 into develop Jun 8, 2023
@drosetti drosetti deleted the react_env branch August 19, 2024 12:48
mlodic added a commit that referenced this pull request Aug 30, 2024
@mlodic
Squashed '.github/' changes from 492bd6d..aa1fe1a
88e5479 
aa1fe1a Merge pull request #211 from certego/develop
7eb2422 Fixed Python configurations
b212b30 Removed "version" from docker-compose files and changed RabbitMQ version
15a8394 fixed flake8-django requirement
79f9e15 updated linters and fixed docker compose v2 (#210)
38136b2 Fix hard link
8b1316d Added supported variables to pull_request_automation.yml
b8990d8 Fix rendering in linter configuration readme for Pycharm
de987f1 Fix rendering in linter configuration readme for Pycharm
7fd3421 Added linter configuration readme for Pycharm
32c1fe3 Merge pull request #206 from certego/develop
1fefb58 Test updates (#204)
29a2608 Update README.md
a22ed57 Update README.md
05044ce Fix rm command
1762e6d Added IDE config for VSCode
d1ba3fc Added Elasticsearch container port as a parameter (#188)
7e56833 Merge pull request #187 from certego/develop
c07ba3c Fix
b916424 Merge pull request #183 from certego/develop
6d88d3f Fix
47300bb Fix arguments
76e6afe Test class + pylint
5df7cf7 Removed escape character
ab983c3 Ignore not `.py` files on pylint
9a447b7 Update README.dev.md
e7af14e Fix readme
33af9af Fix hard links creation
830c127 Added the ability to specify container versions (#186)
8293caa Update README.dev.md
29ead72 Upgrade checkout step
4eb872b Fix download of tags
21e0b41 Allow to fetch latest tag before publishing
15c7b1b Update README.md
46596a8 Update README.md
a106411 Fix pylint
6bfa886 Fix pylint
5cd29dc Fix pylint
4c8826a Fix pylint (#182)
2d859aa Fix revision version

git-subtree-dir: .github
git-subtree-split: aa1fe1a6645fe87ec64c808745cb03159ad32fe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlodic mlodic Awaiting requested review from mlodic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carellamartina @mlodic