Support lazy initialization for empty_xpu#1115
Merged
Merged
Conversation
toyxu
approved these changes
Nov 24, 2024
Contributor
Author
|
XPU build pass and lint is green. Unrelated failures. |
ZhiweiYan-96
pushed a commit
that referenced
this pull request
Dec 2, 2024
# Motivation Fix pytorch/pytorch#140877 Some PyTorch C++ users could call empty op directly. In this situation, lazy initialization would not have been triggered. So we have to add `lazyInitDevice` here, which also aligns with CUDA [convention](https://github.com/pytorch/pytorch/blob/150ffb6e07f3802f8d0d3e843486e77a872803cf/aten/src/ATen/cuda/EmptyTensor.cpp#L13).
ZhiweiYan-96
pushed a commit
that referenced
this pull request
Dec 3, 2024
# Motivation Fix pytorch/pytorch#140877 Some PyTorch C++ users could call empty op directly. In this situation, lazy initialization would not have been triggered. So we have to add `lazyInitDevice` here, which also aligns with CUDA [convention](https://github.com/pytorch/pytorch/blob/150ffb6e07f3802f8d0d3e843486e77a872803cf/aten/src/ATen/cuda/EmptyTensor.cpp#L13).
toyxu
added a commit
that referenced
this pull request
Dec 3, 2024
#### Bugfix - [add lazy init for empty_xpu](#1115) - [nan propagation for soft_shrink](https://github.com/intel/torch-xpu-ops/pull/1116/files#diff-b7cb5876d000db957286c8b0e72badb2b7502402c8955334f1cc21c34c98a5b9) --------- Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com> Co-authored-by: ZhiweiYan-96 <zhiwei.yan@intel.com>
ZhiweiYan-96
pushed a commit
that referenced
this pull request
Jan 16, 2025
# Motivation Fix pytorch/pytorch#140877 Some PyTorch C++ users could call empty op directly. In this situation, lazy initialization would not have been triggered. So we have to add `lazyInitDevice` here, which also aligns with CUDA [convention](https://github.com/pytorch/pytorch/blob/150ffb6e07f3802f8d0d3e843486e77a872803cf/aten/src/ATen/cuda/EmptyTensor.cpp#L13).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix pytorch/pytorch#140877
Some PyTorch C++ users could call empty op directly. In this situation, lazy initialization would not have been triggered. So we have to add
lazyInitDevicehere, which also aligns with CUDA convention.