Skip to content

[Windows][PT2.6] Split larger Other Kernels lib#1096

Merged
toyxu merged 9 commits into
mainfrom
ratnampa/split_windows_lib
Nov 22, 2024
Merged

[Windows][PT2.6] Split larger Other Kernels lib#1096
toyxu merged 9 commits into
mainfrom
ratnampa/split_windows_lib

Conversation

@ratnampa

@ratnampa ratnampa commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

torch_xpu_ops_sycl_kernels leads to around 1.83GB in size on windows, splitting it to reduce the lib size.

New libs introduced in this PR:

torch_xpu_ops_sycl_tensor_srcs
torch_xpu_ops_sycl_norm_loss_srcs
torch_xpu_ops_sycl_poly_srcs
torch_xpu_ops_sycl_dist_srcs

@ratnampa ratnampa requested a review from fengyuan14 November 18, 2024 21:55
Comment thread src/BuildOnWindows.cmake Outdated
Comment thread src/BuildOnWindows.cmake
@fengyuan14

fengyuan14 commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Could you also add xe2-hpg to Windows AOT list in the PR?

@ratnampa

Copy link
Copy Markdown
Contributor Author

Could you also add xe2-hpg to Windows AOT list in the PR?

Sure, will add this one itself.

@ratnampa ratnampa requested a review from fengyuan14 November 19, 2024 22:35
Comment thread src/BuildOnWindows.cmake Outdated
Comment thread src/BuildOnWindows.cmake Outdated
@fengyuan14

Copy link
Copy Markdown
Contributor

LGTM, @ratnampa Could you list the sizes of all kernel libraries in the PR description?

@toyxu toyxu added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit bfdbaf4 Nov 22, 2024
@toyxu toyxu deleted the ratnampa/split_windows_lib branch November 22, 2024 06:05
ZhiweiYan-96 pushed a commit that referenced this pull request Jan 16, 2025
torch_xpu_ops_sycl_kernels leads to around 1.83GB in size on windows,
splitting it to reduce the lib size.

New libs introduced in this PR:

torch_xpu_ops_sycl_tensor_srcs
torch_xpu_ops_sycl_norm_loss_srcs
torch_xpu_ops_sycl_poly_srcs
torch_xpu_ops_sycl_dist_srcs

---------

Co-authored-by: Feng Yuan <feng1.yuan@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants