[SYCL] Add namespace alias for cl::sycl namespace#969
Closed
bader wants to merge 1 commit intointel:syclfrom
Closed
[SYCL] Add namespace alias for cl::sycl namespace#969bader wants to merge 1 commit intointel:syclfrom
bader wants to merge 1 commit intointel:syclfrom
Conversation
The alias is enabled by default and make using SYCL API a little bit
easier.
Unfortunately it's not compatible with the following valid C++ code:
namespace sycl {
using namespace cl::sycl;
}
In order to disable namespace alias user should define
__SYCL_DISABLE_NAMESPACE_ALIAS__ macro.
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
romanovvlad
approved these changes
Dec 25, 2019
Contributor
|
This seems dangerous. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
Renamed `acc` to `accelerator` and removed from the tests where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alias is enabled by default and make using SYCL API a little bit
easier.
Unfortunately it's not compatible with the following valid C++ code:
In order to disable namespace alias user should define
__SYCL_DISABLE_NAMESPACE_ALIAS__macro.Signed-off-by: Alexey Bader alexey.bader@intel.com