[SYCL] [L0] Remove unneeded backwards compatibility of 2023.2 make_queue and get_native.#8871
Merged
againull merged 16 commits intointel:syclfrom May 17, 2023
Merged
[SYCL] [L0] Remove unneeded backwards compatibility of 2023.2 make_queue and get_native.#8871againull merged 16 commits intointel:syclfrom
againull merged 16 commits intointel:syclfrom
Conversation
Contributor
smaslov-intel
left a comment
There was a problem hiding this comment.
LGTM, just few minor comments
smaslov-intel
approved these changes
May 9, 2023
jandres742
approved these changes
May 15, 2023
jchlanda
approved these changes
May 16, 2023
| pi_result cuda_piextQueueGetNativeHandle(pi_queue queue, | ||
| pi_native_handle *nativeHandle) { | ||
| pi_native_handle *nativeHandle, | ||
| int32_t *NativeHandleDesc) { |
Contributor
There was a problem hiding this comment.
Nit: variable names seem to be following camelCase starting with small char (same for pi_hip).
| pi_device device, | ||
| bool ownNativeHandle, | ||
| pi_queue *queue) { | ||
| pi_result cuda_piextQueueCreateWithNativeHandle( |
Contributor
There was a problem hiding this comment.
Nit: camelCase, as above.
Contributor
Author
There was a problem hiding this comment.
The naming convention for parameters is at least consistent with other get_native and make APIs.
gmlueck
approved these changes
May 17, 2023
Contributor
gmlueck
left a comment
There was a problem hiding this comment.
spec changes are OK. (Just an addition of a newline character)
v-klochkov
approved these changes
May 17, 2023
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
…ke_queue and get_native intel#8871 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
…ke_queue and get_native intel#8871 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2023.2 compiler release changed the implementation of get_native(queue) and make_queue to allow use of immediate command lists while maintaining binary compatibility with earlier compiler releases. In 2024.0 we no longer need backwards compatibility and this change removes it.