[SYCL] Add 'cl::sycl::intel::experimental::printf'#835
[SYCL] Add 'cl::sycl::intel::experimental::printf'#835romanovvlad merged 1 commit intointel:syclfrom
Conversation
|
Another approach for the changes in clang: #909 |
f91daff to
52372fd
Compare
52372fd to
198bce3
Compare
29a9b9c to
85bc165
Compare
sycl/test/built-ins/printf.cpp
Outdated
There was a problem hiding this comment.
This is fragile, even for a workaround. I hope this bug is stable
enough.
There was a problem hiding this comment.
From local runs it seems that it is stable enough, yes
85bc165 to
5f245ca
Compare
There was a problem hiding this comment.
Rather than non-standard, there are mostly Intel extensions, aren't they?
There was a problem hiding this comment.
Hmm, at this point I would say it mostly "non-standard" rather than actual Intel extensions, since this file is only contains experimental::printf which doesn't have special extension document
5f245ca to
e18f7ff
Compare
There was a problem hiding this comment.
And if I have cl::sycl::vec<long, 8> on Windows, I have to use %v8d instead of %v8ld, because long is 32bit there, right? We definitely need a correct format diagnostic here (not with this patch). Or maybe Clang can adjust a format string according to the OpenCL rules, since it is guaranteed to be a compile-time constant.
New built-in is mapped to OpenCL 'printf' built-in by using SPIR-V friendly IR. Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com> Co-authored-by: Alexey Sachkov <alexey.sachkov@intel.com>
e18f7ff to
1db211f
Compare
New built-in is mapped to OpenCL 'printf' built-in by using SPIR-V
friendly IR.