[SYCL][Fusion] Cache JIT compiled fused kernels#8051
Merged
steffenlarsen merged 1 commit intointel:syclfrom Jan 27, 2023
Merged
[SYCL][Fusion] Cache JIT compiled fused kernels#8051steffenlarsen merged 1 commit intointel:syclfrom
steffenlarsen merged 1 commit intointel:syclfrom
Conversation
Contributor
Author
|
/verify with intel/llvm-test-suite#1416 |
Contributor
Author
|
Putting up the test for this PR is blocked by review & merge of intel/llvm-test-suite#1416. There is draft PR here, based on another draft PR with the tests for #7831, which in turn is blocked by intel/llvm-test-suite#1416. |
0fa6d61 to
6f49dc5
Compare
victor-eds
suggested changes
Jan 19, 2023
6f49dc5 to
f81936f
Compare
victor-eds
approved these changes
Jan 20, 2023
f81936f to
51f3329
Compare
steffenlarsen
approved these changes
Jan 26, 2023
Contributor
steffenlarsen
left a comment
There was a problem hiding this comment.
Changes look good to me, apart from a small nit.
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
51f3329 to
21a8981
Compare
steffenlarsen
approved these changes
Jan 26, 2023
Contributor
Author
|
@intel/llvm-gatekeepers Can someone please merge, I'm not authorized. |
Contributor
|
Failed Tests (1): Reported in #8098 |
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Feb 7, 2023
Check that JIT compilation for kernel fusion is or is not repeated, depending on whether a newly submitted sequence of kernels is equivalent to a previous sequence. Next to the sequence of kernels, other invocation information, e.g., the user-specified internalization properties play a role to assess equivalence with a previous compilation. Different scenarios are tested by the test added in this PR. Implementation: intel/llvm#8051 Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
) Check that JIT compilation for kernel fusion is or is not repeated, depending on whether a newly submitted sequence of kernels is equivalent to a previous sequence. Next to the sequence of kernels, other invocation information, e.g., the user-specified internalization properties play a role to assess equivalence with a previous compilation. Different scenarios are tested by the test added in this PR. Implementation: intel#8051 Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeating the kernel fusion JIT compilation pipeline if the sequence of kernels to be fused is equivalent to a sequence of kernels fused before.
Next to the sequence of kernels, the detected parameter identities & constants as well as the user-specified internalizations play a role for the equivalence of two sequences. This is all incorporated in the cache lookup.
The JIT compilation caching (on/off) can be controlled through the configuration/environment variable
SYCL_ENABLE_FUSION_CACHING, the default is on.Signed-off-by: Lukas Sommer lukas.sommer@codeplay.com