[SYCL]Fix ESIMD_EMULATOR being picked as default device#6870
Merged
pvchupin merged 24 commits intointel:syclfrom Oct 14, 2022
Merged
[SYCL]Fix ESIMD_EMULATOR being picked as default device#6870pvchupin merged 24 commits intointel:syclfrom
pvchupin merged 24 commits intointel:syclfrom
Conversation
romanovvlad
reviewed
Sep 29, 2022
Contributor
Author
|
Commited another change that extends the filter selector functionality to also accept the esimd_emulator as a valid filter value. |
romanovvlad
suggested changes
Oct 4, 2022
romanovvlad
reviewed
Oct 4, 2022
romanovvlad
reviewed
Oct 5, 2022
Contributor
romanovvlad
left a comment
There was a problem hiding this comment.
LGTM. Do we have a test for the change?
Contributor
Author
|
/verify with intel/llvm-test-suite#1312 |
Contributor
Author
|
This must be merged only after intel/llvm-test-suite#1312 has been merged into llvm-test-suite |
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Oct 14, 2022
The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel/llvm#6870
Contributor
|
Merging in based on prior LGTM from @romanovvlad |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…1312) The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel#6870
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#1312) The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel#6870
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix the problem that occurs when the default device selector picks the ESIMD_EMULATOR when other devices are available.