Skip to content

1wgo4#2702

Closed
rdeodhar wants to merge 5 commits intointel:syclfrom
rdeodhar:1wgo4
Closed

1wgo4#2702
rdeodhar wants to merge 5 commits intointel:syclfrom
rdeodhar:1wgo4

Conversation

@rdeodhar
Copy link
Contributor

No description provided.

@rdeodhar rdeodhar closed this Oct 28, 2020
@rdeodhar rdeodhar deleted the 1wgo4 branch January 15, 2021 17:31
jsji pushed a commit that referenced this pull request Oct 10, 2024
…nce (#2736)

This PR partially fixes issue #2702 in the part that is responsible for SPIR-V to LLVM IR translation. Namely, this PR ensures that all PHI nodes of a Function has the number of incoming blocks matching block's predecessor count. When a PHI node doesn't conform to this rule, this PR inserts missing number of (Value, Basic Block) pairs to make the PHI node valid.

Another problem from #2702, that is violation of the requirement to OpPhi's to have exactly one Parent ID operand for each parent block of the current block in the CFG in the output SPIR-V code, is out of scope of this PR.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@7d7f946dbd51236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant