[SYCL] Deprecate parallel_for and single_task overloads#16145
[SYCL] Deprecate parallel_for and single_task overloads#16145HPS-1 wants to merge 34 commits intointel:syclfrom
Conversation
…xt_oneapi_kernel_properties extension Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
…ings Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
There was a problem hiding this comment.
All deprecation messages indicate that sycl_ext_oneapi_enqueue_functions should be used instead of deprecated APIs.
But do I get it right that user also has a choice to use just regular SYCL 2020 parallel_for/single_task/parallel_for_work_group (queue and handler methods) but with kernel function object (which has a method to return properties) instead of a lambda? I.e. it seems like user doesn't have to use sycl_ext_oneapi_enqueue_functions. Maybe I am missing something.
Probably deprecation message should be fixed to indicate both available options.
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Hi Artur, thanks for reviewing this! So just to let you know I've merged all commits in this PR into one in another PR #16728 to make the commit history cleaner. You can go there for further comments and check new updates. And yes I agree with you -- the main point here is that if the user want to specify (compile-time) properties for a kernel, they can no longer specify such properties as arguments passed to (overloads of) |
Sounds good, thank you! |
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
AlexeySachkov
left a comment
There was a problem hiding this comment.
DeviceCodeSplit/grf.cpp changes LGTM
|
Contents of this PR have been moved to #16728 to make the commit history cleaner. Closing this one to avoid duplication. |
As the title says, added deprecation messages for such overloads in the
sycl_ext_oneapi_kernel_properties extension, suggesting users to usesingle_task/parallel_foroverloads provided in thesycl_ext_oneapi_enqueue_functionsextension instead. (As these overloads are to be removed later as mentioned in #14785) Also fixed affected test cases by adding theWno-deprecated-declarationsbuild flag to let them ignore the deprecation warnings.Also one point to notice:
handlerclass is actually implemented as three function overloads withrange<dimensions>...implemented asrange<1>..., range<2>...andrange<3>...respectively.