[SYCL] Deprecate single_task() and parallel_for() overloads with properties#16728
Merged
AlexeySachkov merged 3 commits intointel:syclfrom Feb 7, 2025
Merged
[SYCL] Deprecate single_task() and parallel_for() overloads with properties#16728AlexeySachkov merged 3 commits intointel:syclfrom
AlexeySachkov merged 3 commits intointel:syclfrom
Conversation
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Contributor
Author
|
Note: the deprecation warnings are all added now. There will be a separate PR to fix the failing e2e tests (#16775) before merging this one. |
Pennycook
approved these changes
Jan 22, 2025
Contributor
Pennycook
left a comment
There was a problem hiding this comment.
I think you got them all 👍 .
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Contributor
Author
|
Requesting @intel/llvm-gatekeepers to merge this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, added deprecation messages for such overloads in the
sycl_ext_oneapi_kernel_properties extension, suggesting users to usesingle_task/parallel_foroverloads provided in thesycl_ext_oneapi_enqueue_functionsextension instead. (As these overloads are to be removed later as mentioned in #14785) Also fixed an affected test case.