[SYCL] Fix conflicting visibility attributes#1571
Merged
bader merged 2 commits intointel:syclfrom Apr 22, 2020
Merged
Conversation
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Contributor
|
@alexbatashev Please, describe the problem eliminated by this patch in patch description. |
Contributor
Author
Done |
Contributor
Were these symbols visible when both modifiers where applied? |
Contributor
Author
I'm not sure. But it caused compile errors on some configurations. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 29, 2020
…versioning * origin/sycl: [XPTI][Framework] Reference implementation of the Xpti framework to be used with instrumentation in SYCL (intel#1557) [SYCL] Initial ABI checks implementation (intel#1528) [SYCL] Support connection with multiple plugins (intel#1490) [SYCL] Add a new header file with the reduction class definition (intel#1558) [SYCL] Add test for SYCL kernels with accessor and spec constant (intel#1536) [SYCL][CUDA] Move interop tests (intel#1570) [Driver][SYCL] Remove COFF object format designator for Windows device compiles (intel#1574) [SYCL] Fix conflicting visibility attributes (intel#1571) [SYCL][DOC] Update the SYCL Runtime Interface document with design details (intel#680) [SYCL] Improve image accessors support on a host device (intel#1502) [SYCL] Make queue's non-USM event ownership temporary (intel#1561) [SYCL] Added support of rounding modes for non-host devices (intel#1463) [SYCL] SemaSYCL significant refactoring (intel#1517) [SYCL] Support 0-dim accessor in handler::copy(accessor, accessor) (intel#1551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inlineimplies internal linkage, when__SYCL_EXPORTsets external linkage. These attributes can't co-exist. Remove__SYCL_EXPORTfor symbols that are supposed to be internal.Signed-off-by: Alexander Batashev alexander.batashev@intel.com