[SYCL] Fix sycl-post-link when no split and symbols are requested.#1454
Merged
bader merged 3 commits intointel:syclfrom Apr 3, 2020
Merged
[SYCL] Fix sycl-post-link when no split and symbols are requested.#1454bader merged 3 commits intointel:syclfrom
bader merged 3 commits intointel:syclfrom
Conversation
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Fznamznon
reviewed
Apr 2, 2020
Contributor
Fznamznon
left a comment
There was a problem hiding this comment.
Generally ok, but please fix tests.
| ; table and a symbol file for an input module with two kernels when no code | ||
| ; splitting is requested. | ||
| ; | ||
| ; RUN: sycl-post-link -symbols -spec-const=rt -S %s -o %T/files.table |
Contributor
There was a problem hiding this comment.
I suppose tests are failing in pre-commit due conflict of test files.
Suggested change
| ; RUN: sycl-post-link -symbols -spec-const=rt -S %s -o %T/files.table | |
| ; RUN: sycl-post-link -symbols -spec-const=rt -S %s -o %T/%t.files.table |
Contributor
Author
There was a problem hiding this comment.
thanks for the hint, BTW )
Comment on lines
+124
to
+125
| // Describes scope covered by each entry in the module-kernel map populated by | ||
| // the function below. |
Contributor
There was a problem hiding this comment.
Hmm, what if someone would come and made this comment invalid by adding new function after this enum...
Suggested change
| // Describes scope covered by each entry in the module-kernel map populated by | |
| // the function below. | |
| // Describes scope covered by each entry in the module-kernel map populated by | |
| // the collectKernelModuleMap function. |
Comment on lines
132
to
134
| // Output parameter ResKernelModuleMap is a map containing groups of kernels | ||
| // with same values of the sycl-module-id attribute. | ||
| // The function fills ResKernelModuleMap using input module M. |
Contributor
There was a problem hiding this comment.
I think we should rewrite this comment somehow.
Contributor
Author
There was a problem hiding this comment.
the comment has been invalid since addition of per-kernel split before my changes.
But OK, I'll go ahead and change the comment
Comment on lines
+149
to
+151
| error("no '" + Twine(ATTR_SYCL_MODULE_ID) + | ||
| "' attribute in kernel '" + F.getName() + | ||
| "', per-module split not possible"); |
Contributor
There was a problem hiding this comment.
Should we group kernels without this attribute into a separate module?
Contributor
Author
There was a problem hiding this comment.
I don't know, maybe. The answer would be 'yes' if there are practical scenarios where per-module splitting is requested on modules with functions w/o module-id attribute. This would be a topic for a separate PR, anyway.
Here I just protect from the existing problem that I noticed - silent dropping of kernels w/o module-id attribute in -split=source mode. What I can do now is add a TODO.
Contributor
There was a problem hiding this comment.
Sure. I thought about this case while implementing split, but I didn't come up with the viable case when it is possible to get such module containing kernels with and without module-id attribute.
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
01c8bd3 to
27b88f5
Compare
Fznamznon
previously approved these changes
Apr 3, 2020
Co-Authored-By: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Fznamznon
approved these changes
Apr 3, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 6, 2020
…_private_api * origin/sycl: (614 commits) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) [SYCL] Fix sycl-post-link when no split and symbols are requested. (intel#1454) [SYCL] Change priority of devices in default_selector (intel#1264) [CI] Update CODEOWNERS matching rules order (intel#1468) [SYCL] Share PFWG lambda object through shared memory (intel#1455) [CI] Fix CODEOWNERS file syntax (intel#1464) [SYCL][CUDA] Fix active context when creating base event (intel#1447) [SYCL] Diagnose implicit declaration of kernel function type (intel#1450) [BuildBot] Modify configure script (intel#1421) [SYCL] Resolve min/max conflict (intel#1339) [CI][BuildBot] Fix configure parameter to turn on/off assertions (intel#1449) [SYCL] XFAIL LIT test due to duplicate diagnostic [SYCL] Remove explicit sycl_device attribute requirement Apply more suggestions Apply suggestions Translate new set of Intel FPGA Loop Controls Translate Intel FPGA force_pow2_depth memory attribute ...
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 15, 2020
…c_abi_checks * origin/sycl: (625 commits) [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488) [SYCL] Only export public API (intel#1456) [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475) [SYCL] Enable LIT testing with CUDA BE (intel#1458) [SYCL] Fix float to half-type conversion (intel#1395) [NFC] Cleanup unneded macro from builtins implementation (intel#1445) Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479) [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) [SYCL] Fix sycl-post-link when no split and symbols are requested. (intel#1454) [SYCL] Change priority of devices in default_selector (intel#1264) [CI] Update CODEOWNERS matching rules order (intel#1468) [SYCL] Share PFWG lambda object through shared memory (intel#1455) [CI] Fix CODEOWNERS file syntax (intel#1464) [SYCL][CUDA] Fix active context when creating base event (intel#1447) [SYCL] Diagnose implicit declaration of kernel function type (intel#1450) [BuildBot] Modify configure script (intel#1421) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com