[SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON#1323
Merged
bader merged 1 commit intointel:syclfrom Mar 18, 2020
Merged
[SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON#1323bader merged 1 commit intointel:syclfrom
bader merged 1 commit intointel:syclfrom
Conversation
Explicitly link llvm-spirv with the libLLVMSPIRVLib.a static library even if building LLVM/clang with -DLLVM_LINK_LLVM_DYLIB=ON . Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
Contributor
Author
|
This seems to fix #1322, though I don't know if that is the correct fix or just a workaround. |
Contributor
Author
|
@vladimirlaz @bader could you review this ? |
Contributor
Author
|
Upstream PR: KhronosGroup/SPIRV-LLVM-Translator#458 . |
bader
approved these changes
Mar 18, 2020
Contributor
The patch is merged to Khronos repo. I think we should close the PR, the change will get to intel/llvm during next pull down. @vladimirlaz UPD. :( Ok, the patch is merged, github has not show me that initially. |
Contributor
It will keep @fwyzard happy until @vladimirlaz is working on pulling Khronos patches. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 20, 2020
* sycl: (1209 commits) [SYCL] Check exit status get_device_count_by_type [SYCL][Doc] Update sub-group extension docs (intel#1330) [SYCL][Doc] Add leader to GroupAlgorithms (intel#1297) [SYCL] Add SYCL headers search path to default compilation options (intel#1347) [SYCL][PI] Add interoperability with generic handles to device and program classes (intel#1244) Move SPIR devicelib to top level (intel#1276) [SYCL][Driver] Improve fat static library support (intel#1319) [SYCL] Remove image_api LIT (intel#1349) [SYCL] Fix headers location for check-sycl-deploy target [SYCL] Allow gcc asm statements in kernel code (intel#1341) [SYCL] Add Intel FPGA force_pow2_depth attribute (intel#1284) [SPIR-V][NFC] Fix for building llvm-spirv with -DLLVM_LINK_LLVM_DYLIB=ON (intel#1323) [SYCL][NFC] Fix execution graph dump (intel#1331) [SYCL][Doc] Release SYCL_INTEL_enqueue_barrier extension document (intel#1199) [SYCL][USM] Fix USM malloc_shared and free to handle zero byte (intel#1273) [SYCL] Fix undefined symbols in async_work_group_copy (intel#1243) [SYCL] Mark calls to barrier and work-item functions as convergent [SYCL][CUDA] Fix CUDA plug-in build with enabled assertions (intel#1325) [SYCL][Test] Add OpenCL requirement to test/ordered_queue/prop.cpp (intel#1335) [SYCL][CUDA] Improve CUDA backend documentation (intel#1293) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly link
llvm-spirvwith thelibLLVMSPIRVLib.astatic library even if building LLVM/clang with-DLLVM_LINK_LLVM_DYLIB=ON.