[SYCL] Do not remove commands from leaves lists on subuffer creation#1196
Merged
bader merged 1 commit intointel:syclfrom Feb 27, 2020
Merged
Conversation
Contributor
KarachunIvan
left a comment
There was a problem hiding this comment.
LGTM, but could you please fix the typo in the commit message?
subuffer -> sub-buffer.
Contributor
Author
Will fix during merge. UPD. Updated commit message as I had to rebase the patch anyway. |
sergey-semenov
previously approved these changes
Feb 26, 2020
It's not correct to remove commands from leaves that we are not depending on. Signed-off-by: Vlad Romanov <vlad.romanov@intel.com>
1cc2f30 to
8aa91e7
Compare
KarachunIvan
approved these changes
Feb 26, 2020
bb-sycl
pushed a commit
that referenced
this pull request
Jun 1, 2022
As per issue #1196, the loop induction variable, which is an argument in the omp.wsloop operation, does not have a memory location, so when passed to a function or subroutine, the reference to the value is not a memory location, but the value of the induction variable. The callee function/subroutine is then trying to dereference memory at address 1 or some other "not a good memory location". This is fixed by creating a temporary memory location and storing the value of the induction variable in that. Test fixes as a consequence of the changed code generated. Add checking for some of the omp-unstructured.f90 to check for alloca, store and load operations, to ensure the correct flow. Add a test for CYCLE inside a omp-do loop. Also convert to use -emit-fir in the omp-unstructrued, and make the symbol matching consistent in the omp-wsloop-variable test. Reviewed By: peixin Differential Revision: https://reviews.llvm.org/D126711
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/AOT. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com> Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not correct to remove commands from leaves that we are not
depending on.
Signed-off-by: Vlad Romanov vlad.romanov@intel.com